»
« home   paste   Anonymous | Login | Signup for a new account 09-22-2017 15:31 CEST
 
* X »
«
GeSHi - Generic Syntax Highlighter Syntax Coloriser for PHP
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000010 [GeSHi] core minor sometimes 10-21-05 00:20 02-18-06 11:54
Reporter Jossele View Status public  
Assigned To nigel
Priority normal Resolution fixed  
Status closed   Product Version 1.1.1alpha1
Summary 0000010: var: Deprecated
Description PHP5 Reports:
Error "var: Deprecated. Please use the public/private/protected modifiers" in file class.geshi.php, line 192
Additional Information
Attached Files

- Relationships
related to 0000023closed nigel Fatal error using get-keywords script 

- Notes
(0000005)
nigel
10-21-05 12:15

Are you using E_ALL & E_STRICT? You will get this error if you are.

What I can do is explicitly turn error reporting to E_ALL before the GeSHi class and then turn it back to what it was after.
 
(0000027)
nigel
10-26-05 01:24

Fix is in CVS. When 1.1.1alpha2 comes out I'll need someone to test this, since I have no access to PHP5 myself.
 
(0000031)
BenBE
10-26-05 07:11

I have PHP5 for local testing. Just tell me what specific script to test for you...
 
(0000033)
nigel
10-26-05 13:27

Just write a script like this:

<?php
error_reporting(E_ALL & E_STRICT);
require_once 'class.geshi.php';

$geshi =& new GeSHi('interface foo', 'delphi');
echo $geshi->parseCode();

?>

And see what output you get. I get this feeling I'll have to do this hack for some of the other files also (like class.geshicodeparser.php and others in geshi/classes)
 
(0000041)
nigel
11-01-05 14:02

1.1.1alpha2 is out, could you check this bug? I said it was fixed in that release but I get this feeling that it's not.
 
(0000044)
BenBE
11-02-05 08:32

Will try to do during the next days. But probably not before thrusday evening ... Will tell when I'm done with it.
 
(0000065)
BenBE
11-21-05 05:57

I reverified the changes against current CVS release and got no messages using the given test script. Seems to work now.

I'm sorry that it took so long to test this little source ...
 
(0000066)
nigel
11-21-05 09:33

I'm still not sure whether this has been entirely fixed, so let's not close it yet.

I think that some of the other scripts may cause a problem. For example, if class.geshicodeparser.php is require()d after class.geshi.php has finished being included (and thus error reporting is back to normal value), then there may be warnings.

But it's pretty low priority to fix, so I'll just leave it as "resolved" for now.
 
(0000340)
nigel
02-18-06 11:54

Issue closed.
 

- Issue History
Date Modified Username Field Change
10-21-05 00:20 Jossele New Issue
10-21-05 12:15 nigel Note Added: 0000005
10-21-05 12:15 nigel Assigned To  => nigel
10-21-05 12:15 nigel Status new => acknowledged
10-26-05 01:24 nigel Note Added: 0000027
10-26-05 01:26 nigel Status acknowledged => assigned
10-26-05 01:26 nigel Resolution open => fixed
10-26-05 07:11 BenBE Note Added: 0000031
10-26-05 13:27 nigel Note Added: 0000033
11-01-05 14:02 nigel Note Added: 0000041
11-02-05 08:32 BenBE Note Added: 0000044
11-20-05 05:21 BenBE Relationship added related to 0000023
11-20-05 16:51 nigel Status assigned => feedback
11-21-05 05:57 BenBE Note Added: 0000065
11-21-05 05:57 BenBE Status feedback => resolved
11-21-05 05:57 BenBE Fixed in Version  => 1.1.1alpha3
11-21-05 09:33 nigel Note Added: 0000066
02-18-06 11:54 nigel Status resolved => closed
02-18-06 11:54 nigel Note Added: 0000340

  


Mantis 1.0.0rc2[^]
Copyright © 2000 - 2005 Mantis Group
51 total queries executed.
37 unique queries executed.
Powered by Mantis Bugtracker