»
« home   paste   Anonymous | Login | Signup for a new account 04-26-2017 13:51 CEST
 
* X »
«
GeSHi - Generic Syntax Highlighter Syntax Coloriser for PHP
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000040 [GeSHi] lang minor always 12-13-05 13:42 02-18-06 11:47
Reporter tim-w View Status public  
Assigned To tim-w
Priority low Resolution fixed  
Status closed   Product Version 1.1.1alpha3
Summary 0000040: Split Java keywords into smaller groups
Description As discussed on the Java meta-bug, it would be a good idea if the class keywords were split into smaller categories, for example into their packages (java.applet, java.awt, java.awt.color...)
Additional Information Java 1.5 API docs: http://java.sun.com/j2se/1.5.0/docs/api/index.html [^]

The good thing about doing this is that then URLs can be specified for the keywords more accurately.
Attached Files

- Relationships
child of 0000039assigned tim-w Java support 

- Notes
(0000141)
BenBE
12-15-05 08:54

While looking through the file I noticed some things

1. (important) Array group 3 is used twice. There's a doubled reference at the end of the keywords array that should be renamed group 168

2. (important) Some groups contain keywords with "." in their name. Please recheck if that are real classes or just subproperties.

3. (medium) @nigel: Should we use "/" in context names? Or leave "." as it is ATM?

4. (medium) Shouldn't it be " instead of ' on lines 3064:
$this->_contextCharactersDisallowedBeforeKeywords = array('\'');
$this->_contextCharactersDisallowedAfterKeywords = array('\'');
-->
$this->_contextCharactersDisallowedBeforeKeywords = array("\'");
$this->_contextCharactersDisallowedAfterKeywords = array("\'");
 
(0000142)
nigel
12-15-05 09:40

It should be /, I mentioned that to Tim already.

As for 0000004: nope, the first way is fine. The second way actually looks for the string sequence \', which is more than one character.
 
(0000143)
BenBE
12-15-05 10:05

@4: Isn't it "\'" the ' char in PHP? That is IMHO the same problem I had in my source using '\n' unstead of "\n". That's y I'm asking.
 
(0000144)
nigel
12-15-05 12:10

No, not in " strings. There's no need to escape a ' in a double string :p
 
(0000145)
tim-w
12-15-05 12:34

-The duplicate Array group 3 has been removed
-The .'s are now replaced with /'s

As for the keywords with "."'s in their name they
are either
-Classes
-Interfaces
-Enums
-Exceptions

If you can find one that is not one of these things then
post it up here. I've had a check and haven't seen any yet.

In fact it is actually quite common in Java to have Classes
with a "." in their name.




 
(0000146)
nigel
12-15-05 13:23

[no need to hide your comments Tim ;)]
 
(0000147)
BenBE
12-16-05 01:50

k, Just wondered. Maybe I saw some subclasses e.g. the BeanControl ones have some of them in there. I'm not that familiar, but if I say that are common class names maybe you could do some "trick" in the JCP to make the . look as if it was normal symbol, but with same context as the name itself

@nigel: I mean something like
if token contains . and is Ident\Classname then
    Split by . and highlight each part as context, each . as language symbol
fi
 
(0000148)
nigel
12-16-05 09:49

Yes, that sounds like a sensible use of the codeparser.
 
(0000151)
nigel
12-17-05 18:20

This issue is resolved.
 
(0000330)
nigel
02-18-06 11:47

Issue closed.
 

- Issue History
Date Modified Username Field Change
12-13-05 13:42 nigel New Issue
12-13-05 13:42 nigel Status new => assigned
12-13-05 13:42 nigel Assigned To  => tim-w
12-13-05 23:12 BenBE Relationship added child of 0000039
12-15-05 08:54 BenBE Note Added: 0000141
12-15-05 09:40 nigel Note Added: 0000142
12-15-05 10:05 BenBE Note Added: 0000143
12-15-05 12:10 nigel Note Added: 0000144
12-15-05 12:34 tim-w Note Added: 0000145
12-15-05 12:34 tim-w Reporter nigel => tim-w
12-15-05 12:34 tim-w Note View State: private: 145
12-15-05 13:23 nigel Note View State: public: 145
12-15-05 13:23 nigel Note Added: 0000146
12-16-05 01:50 BenBE Note Added: 0000147
12-16-05 09:49 nigel Note Added: 0000148
12-17-05 18:20 nigel Note Added: 0000151
12-17-05 18:20 nigel Status assigned => resolved
12-17-05 18:20 nigel Resolution open => fixed
12-17-05 18:20 nigel Fixed in Version  => 1.1.1alpha3
02-18-06 11:47 nigel Status resolved => closed
02-18-06 11:47 nigel Note Added: 0000330

  


Mantis 1.0.0rc2[^]
Copyright © 2000 - 2005 Mantis Group
56 total queries executed.
39 unique queries executed.
Powered by Mantis Bugtracker