»
« home   paste   Anonymous | Login | Signup for a new account 01-24-2019 05:14 CET
 
* X »
«
GeSHi - Generic Syntax Highlighter Syntax Coloriser for PHP
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000067 [GeSHi phpBB MOD] core major N/A 02-09-06 09:29 04-24-06 04:59
Reporter nigel View Status public  
Assigned To
Priority normal Resolution open  
Status feedback  
Summary 0000067: GeSHi phpBB mod discussion
Description We need to discuss all of the possible features that the MOD should have, and its architecture etc.
Additional Information
Attached Files

- Relationships
related to 0000088assigned BenBE Drop support for phpBB mod 

- Notes
(0000296)
nigel
02-09-06 09:50

Firstly, what restrictions?

GeSHi 1.0.x should be used.
The MOD should install on the latest vanilla subSilver phpBB.
All MOD dev policies that phpBB specifies should be followed.

What features? (ignoring the current codebase)

  * Highlight all languages that come with GeSHi
    - this includes allowing the user to write their own language files and "drag&drop" the file
      o This means that if languages have preferences (like the current version does: one preference is the "name that should be displayed" for example), there should be a way to allow the user to rescan for languages

  * Highlight using various GeSHi options
    - line numbers on/off
      o Have board config: yes/no/defer (e.g. let user decide)
      o Have user config: yes/no/defer (e.g. let poster decide)
      o When posting: yes/no/defer
      o So the admin could decide "always on for everyone", "always off" etc. The user could decide they want them always on or off, but their choice only applies if the admin hasn't chosen an option. The poster could also say "on/off", but only if the user and admin prefs don't mind

    - Using CSS classes: Assuming that users could write new languages, if we force them to use CSS they may complain that "I wrote language foo but it's not highlighted". So allow them to choose.

  * Cache
    - Vitally important. Current MOD does this so you can see how it's done.


Some general things:

  * If we make a web-accessable website or test board for it, it will be at http://geshi-phpbb.sourceforge.net/. [^] No point wasting all that space :)
  * I can handle project releases etc. through sourceforge, but one of you guys should handle the phpBB dev thread (which should NOT be set up yet)
  * We may as well use sourceforge for much of this stuff. We can file bugs here or on the sf.net tracker, and we won't mind if the public file them in either place for now.
 
(0000297)
BenBE
02-09-06 11:13

I'd like to add some minor things:

- There should be added a way to tell the board if you want [syntax="Delphi"] or [delphi] style tags
- In advance you should be able to specify a title for the source (example taken from the Delphi forum syntax tags): [delphi="HelloWorld.pas"(25)] creating a title 25 with source numbering starting at line 25 (preceeded by a line with a comment {...}).
- The Mod should allow for Source folding\unfolding
- There should be a way to copy to clipboard the source by single click
- Maybe a "Download this source"-function would be nice.

What are the coding rules for phpBB? Include as many files at as many unpredictable places to produce most unpredictable behaviour when changing something, or did I get something wrong??? Please tell in some more detail.

There should be support for multiple versions, i.e. not only the latest vanilla version, but prior versions too if work isn't too much (for maintaince) ... I've a local copy of a repository covering all phpBB2s' versions. Maybe you could do changes againstthos branches easily ...

Could you allow for each user to setup it's color theme itself (in the profile)???

That's for now ... more ideas follow ...
 
(0000299)
nigel
02-09-06 15:52

>- There should be added a way to tell the board if you want [syntax="Delphi"]
> or [delphi] style tags

Allow them both, don't bother with a choice.

>- In advance you should be able to specify a title for the source (example
> taken from the Delphi forum syntax tags): [delphi="HelloWorld.pas"(25)]
> creating a title 25 with source numbering starting at line 25 (preceeded by a
> line with a comment {...}).

Not a bad idea, though I don't know about the format specifying options, I think it should be more like [delphi title="HellowWorld.pas" lns="25"], that way we can add more if needed.

>- The Mod should allow for Source folding\unfolding

Integration with the "select/expand" mod may also be worthwile, I was in talks with the author of that mod beforehand.

> - There should be a way to copy to clipboard the source by single click

That will only ever work in windows, linux does not support the insecure javascript copy function. Far better is to provide a button to turn line numbers off and another button to select all of the source, then the user can copy with Ctrl+C as usual.

> - Maybe a "Download this source"-function would be nice.

Maybe

> What are the coding rules for phpBB? Include as many files at as many
> unpredictable places to produce most unpredictable behaviour when changing
> something, or did I get something wrong??? Please tell in some more detail.

Welcome to the wonderful world of phpBB.

But in particular, refer to http://phpbb.com/kb/ [^] - especially the MOD related documents and coding standards.

> There should be support for multiple versions, i.e. not only the latest
> vanilla version, but prior versions too if work isn't too much (for
> maintaince) ... I've a local copy of a repository covering all phpBB2s'
> versions. Maybe you could do changes againstthos branches easily ...

Dunno about this, since every version since the most recent one in theory has security holes and so the admin should have upgraded...

> Could you allow for each user to setup it's color theme itself (in the
> profile)???

The last version chained the colours to the theme the user was using (because it was easy to put a different stylesheet in each theme directory), but if you think it's useful then why not.
 
(0000346)
nigel
04-23-06 14:00

I don't think there's too much point of continuing with this MOD really, since nobody has the time to bother with it. Thoughts?
 
(0000350)
BenBE
04-24-06 04:59

At least at current stage there's not much to incorperate into the MOD since for the old GeSHi it works and it's not worth the time to include the additional features into a product line that is to be obsoleted. Work on this MOD should be delayed until 1.1 line is far enought to compet with current stable branch.
 

- Issue History
Date Modified Username Field Change
02-09-06 09:29 nigel New Issue
02-09-06 09:50 nigel Note Added: 0000296
02-09-06 09:51 nigel Status new => feedback
02-09-06 11:13 BenBE Note Added: 0000297
02-09-06 11:23 BenBE Note Added: 0000298
02-09-06 15:52 nigel Note Added: 0000299
02-09-06 15:55 nigel Note Added: 0000300
04-23-06 14:00 nigel Note Added: 0000346
04-24-06 04:59 BenBE Note Added: 0000350
09-13-06 13:26 BenBE Relationship added related to 0000088

  


Mantis 1.0.0rc2[^]
Copyright © 2000 - 2005 Mantis Group
44 total queries executed.
32 unique queries executed.
Powered by Mantis Bugtracker